Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](index writer) fix dead lock when closeInternal catches CLuceneError #207

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

airborne12
Copy link
Member

This pull request addresses an issue within the closeInternal method.
When Thread A invokes closeInternal and encounters a CLucene error, the method exits without setting the closing flag back to false.
As a result, if another Thread B subsequently calls closeInternal and enters the waitForClose method, it becomes trapped in an infinite loop.

Copy link
Collaborator

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit 70d7a7b into apache:clucene Mar 26, 2024
3 of 4 checks passed
qidaye pushed a commit to qidaye/doris-thirdparty that referenced this pull request May 9, 2024
…rror (apache#207)

This pull request addresses an issue within the closeInternal method. 
When Thread A invokes closeInternal and encounters a CLucene error, the method exits without setting the closing flag back to false. 
As a result, if another Thread B subsequently calls closeInternal and enters the waitForClose method, it becomes trapped in an infinite loop.
airborne12 added a commit to airborne12/doris-thirdparty that referenced this pull request May 9, 2024
…rror (apache#207)

This pull request addresses an issue within the closeInternal method. 
When Thread A invokes closeInternal and encounters a CLucene error, the method exits without setting the closing flag back to false. 
As a result, if another Thread B subsequently calls closeInternal and enters the waitForClose method, it becomes trapped in an infinite loop.
qidaye pushed a commit that referenced this pull request May 9, 2024
…ceneError (#207) (#212)

This pull request addresses an issue within the closeInternal method. 
When Thread A invokes closeInternal and encounters a CLucene error, the method exits without setting the closing flag back to false. 
As a result, if another Thread B subsequently calls closeInternal and enters the waitForClose method, it becomes trapped in an infinite loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants