Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](group commit) fix group commit use prepared statement and connect to observer #46206

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[fix](group commit) fix group commit use prepared statement and connect to observer #46206

merged 1 commit into from
Jan 2, 2025
+34 −4

Conversation

mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Dec 31, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

if use prepared statement and connect to observer, will get:

detailMessage = Forward master command is not supported for prepare statement

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 31, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Dec 31, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32576 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5288bd6a49f90a8c904035bb66589394a06a1bff, data reload: false

------ Round 1 ----------------------------------
q1	17570	6246	6053	6053
q2	2047	301	171	171
q3	10417	1212	733	733
q4	10216	863	438	438
q5	7492	2159	1965	1965
q6	210	178	144	144
q7	885	749	604	604
q8	9239	1316	1112	1112
q9	5184	4899	4944	4899
q10	6751	2294	1861	1861
q11	473	278	254	254
q12	349	364	231	231
q13	17968	3744	3057	3057
q14	250	239	223	223
q15	590	497	499	497
q16	630	626	600	600
q17	597	859	335	335
q18	6939	6395	6443	6395
q19	1659	957	555	555
q20	306	327	183	183
q21	2796	2172	1945	1945
q22	371	337	321	321
Total cold run time: 102939 ms
Total hot run time: 32576 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6244	6206	6236	6206
q2	234	329	234	234
q3	2257	2649	2340	2340
q4	1463	1839	1417	1417
q5	4362	4814	4765	4765
q6	190	185	141	141
q7	2080	1975	1803	1803
q8	2610	2834	2685	2685
q9	7359	7279	7326	7279
q10	3075	3357	2813	2813
q11	568	521	495	495
q12	666	786	638	638
q13	3402	3747	3158	3158
q14	293	298	287	287
q15	576	520	508	508
q16	655	682	641	641
q17	1249	1720	1238	1238
q18	7709	7364	7281	7281
q19	833	1195	1060	1060
q20	2036	2024	1858	1858
q21	5635	5202	4885	4885
q22	599	616	606	606
Total cold run time: 54095 ms
Total hot run time: 52338 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196671 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5288bd6a49f90a8c904035bb66589394a06a1bff, data reload: false

query1	1295	962	915	915
query2	6267	2413	2303	2303
query3	10985	4802	4834	4802
query4	33449	23792	23483	23483
query5	4691	621	469	469
query6	299	205	193	193
query7	4006	499	303	303
query8	298	246	230	230
query9	9324	2693	2700	2693
query10	489	322	246	246
query11	18092	15576	15232	15232
query12	156	102	97	97
query13	1558	517	398	398
query14	10741	6897	7200	6897
query15	242	220	193	193
query16	8036	648	477	477
query17	1509	755	613	613
query18	2159	401	321	321
query19	187	182	160	160
query20	116	114	111	111
query21	212	125	106	106
query22	4529	4698	4429	4429
query23	34446	33463	33403	33403
query24	6409	2333	2310	2310
query25	489	440	400	400
query26	733	281	158	158
query27	2139	462	329	329
query28	5324	2451	2469	2451
query29	651	563	442	442
query30	209	188	146	146
query31	990	923	847	847
query32	94	60	61	60
query33	489	360	308	308
query34	764	869	518	518
query35	808	848	792	792
query36	1051	1085	1030	1030
query37	113	98	77	77
query38	4252	4338	4282	4282
query39	1530	1467	1472	1467
query40	208	112	97	97
query41	46	43	43	43
query42	116	103	109	103
query43	536	540	500	500
query44	1311	850	821	821
query45	182	174	170	170
query46	873	1075	659	659
query47	2015	1997	1940	1940
query48	399	410	315	315
query49	707	475	389	389
query50	627	674	411	411
query51	7303	7313	7280	7280
query52	107	105	94	94
query53	225	254	183	183
query54	487	504	436	436
query55	82	84	82	82
query56	258	287	269	269
query57	1273	1224	1182	1182
query58	244	227	232	227
query59	3429	3266	3319	3266
query60	285	281	265	265
query61	131	139	127	127
query62	890	858	759	759
query63	225	192	190	190
query64	3262	1006	666	666
query65	3346	3324	3272	3272
query66	782	413	317	317
query67	16402	15820	15467	15467
query68	10037	816	511	511
query69	476	291	255	255
query70	1169	1163	1124	1124
query71	468	273	257	257
query72	5913	3859	3826	3826
query73	654	761	362	362
query74	10160	9462	8987	8987
query75	4607	3133	2640	2640
query76	5317	1201	790	790
query77	1026	357	283	283
query78	10035	10222	9467	9467
query79	5602	882	593	593
query80	714	511	430	430
query81	489	268	237	237
query82	658	145	126	126
query83	190	167	146	146
query84	278	95	69	69
query85	752	432	301	301
query86	353	293	295	293
query87	4610	4518	4283	4283
query88	3666	2255	2229	2229
query89	464	335	295	295
query90	2108	184	187	184
query91	132	135	103	103
query92	66	57	52	52
query93	3452	888	522	522
query94	668	394	294	294
query95	335	266	255	255
query96	486	628	286	286
query97	2753	2848	2619	2619
query98	232	194	194	194
query99	1750	1556	1437	1437
Total cold run time: 304502 ms
Total hot run time: 196671 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5288bd6a49f90a8c904035bb66589394a06a1bff, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.68	0.11	0.11
query5	0.41	0.43	0.41
query6	1.37	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.52	0.50
query10	0.55	0.56	0.55
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.76	2.73	2.83
query15	0.89	0.83	0.82
query16	0.38	0.37	0.40
query17	1.02	1.04	0.99
query18	0.24	0.21	0.21
query19	1.89	1.77	2.05
query20	0.01	0.00	0.01
query21	15.36	0.97	0.59
query22	0.77	0.78	0.59
query23	15.38	1.42	0.51
query24	3.74	1.25	0.44
query25	0.26	0.14	0.07
query26	0.36	0.15	0.15
query27	0.06	0.07	0.04
query28	13.18	1.52	1.05
query29	12.57	3.96	3.33
query30	0.25	0.09	0.06
query31	2.84	0.58	0.38
query32	3.23	0.55	0.45
query33	3.14	3.10	3.09
query34	16.94	5.11	4.49
query35	4.50	4.43	4.49
query36	0.63	0.51	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.8 s
Total hot run time: 30.59 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 2, 2025

run feut

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jan 2, 2025

run fe_ut

eldenmoon
eldenmoon approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit da94a2a into apache:master Jan 2, 2025
25 of 26 checks passed
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jan 3, 2025
@mymeiyi
[fix](group commit) fix group commit use prepared statement and conne…
0e6e525 
…ct to observer (apache#46206)

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

if use prepared statement and connect to observer, will get:
```
detailMessage = Forward master command is not supported for prepare statement
```
@mymeiyi mymeiyi mentioned this pull request Jan 3, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jan 3, 2025
@mymeiyi
[fix](group commit) fix group commit use prepared statement and conne…
8d693cd 
…ct to observer (#46206) (#46344)

pick #46206
@dataroaring dataroaring added usercase Important user case type label dev/3.0.4-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mymeiyi @Thearas @doris-robot @eldenmoon @morrySnow @dataroaring