Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](regression-test) fix test_outfile_csv_with_names_and_types case #46214

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[fix](regression-test) fix test_outfile_csv_with_names_and_types case #46214

merged 1 commit into from
Jan 2, 2025

Conversation

BePPPower
Copy link
Contributor

Problem Summary:
fix test_outfile_csv_with_names_and_types case

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BePPPower
Copy link
Contributor Author

run buildall

morningman
morningman approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit 700069c into apache:master Jan 2, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 2, 2025
@BePPPower
[fix](regression-test) fix test_outfile_csv_with_names_and_types ca…
ddb2d2b 
…se (#46214)

Problem Summary:
fix `test_outfile_csv_with_names_and_types` case
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jan 2, 2025
@BePPPower
[fix](regression-test) fix test_outfile_csv_with_names_and_types ca…
af92ce0 
…se (#46214)

Problem Summary:
fix `test_outfile_csv_with_names_and_types` case
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 2, 2025
@github-actions @BePPPower
branch-2.1: [fix](regression-test) fix `test_outfile_csv_with_names_a…
7e615af 
…nd_types` case #46214 (#46272)

Cherry-picked from #46214

Co-authored-by: Tiewei Fang <[email protected]>
morningman pushed a commit that referenced this pull request Jan 2, 2025
@github-actions @BePPPower
branch-3.0: [fix](regression-test) fix `test_outfile_csv_with_names_a…
569adde 
…nd_types` case #46214 (#46270)

Cherry-picked from #46214

Co-authored-by: Tiewei Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubgeter hubgeter hubgeter approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BePPPower @hello-stephen @morningman @CalvinKirs @zy-kkk @hubgeter @yiguolei