Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature](cloud) Support rename compute group sql #46221

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[feature](cloud) Support rename compute group sql #46221

wants to merge 4 commits into from
+428 −17

Conversation

deardeng
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng deardeng marked this pull request as draft December 31, 2024 11:22
@deardeng deardeng force-pushed the add-alter-rename-cluster branch from 8f724c8 to 1b06073 Compare December 31, 2024 11:30
@deardeng deardeng force-pushed the add-alter-rename-cluster branch from 1b06073 to 904a306 Compare December 31, 2024 11:37
@deardeng
Copy link
Contributor Author

wait add regression case

gavinchou
gavinchou reviewed Jan 1, 2025
View reviewed changes
gensrc/proto/cloud.proto Outdated Show resolved Hide resolved
@deardeng deardeng force-pushed the add-alter-rename-cluster branch from d0d3496 to 9a7f69a Compare January 2, 2025 03:14
@deardeng deardeng marked this pull request as ready for review January 2, 2025 09:56
@deardeng
Copy link
Contributor Author

deardeng commented Jan 2, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33015 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b08a6c13a6ec879671677db1b5e9179387d71044, data reload: false

------ Round 1 ----------------------------------
q1	17576	6162	6061	6061
q2	2044	295	172	172
q3	10420	1310	756	756
q4	10226	890	435	435
q5	7531	2265	1992	1992
q6	206	184	147	147
q7	927	753	611	611
q8	9239	1407	1261	1261
q9	5280	4897	5050	4897
q10	6768	2321	1900	1900
q11	482	283	268	268
q12	351	369	216	216
q13	17780	3772	3167	3167
q14	232	238	230	230
q15	569	508	497	497
q16	647	624	591	591
q17	624	867	348	348
q18	7318	6562	6426	6426
q19	1305	971	555	555
q20	313	322	192	192
q21	2946	2241	1983	1983
q22	364	327	310	310
Total cold run time: 103148 ms
Total hot run time: 33015 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6258	6242	6299	6242
q2	235	323	228	228
q3	2266	2688	2339	2339
q4	1415	1886	1349	1349
q5	4376	4831	4914	4831
q6	187	174	142	142
q7	2128	1983	1808	1808
q8	2634	2827	2719	2719
q9	7405	7323	7260	7260
q10	3076	3357	2858	2858
q11	600	517	512	512
q12	652	744	580	580
q13	3521	3824	3138	3138
q14	281	317	296	296
q15	576	527	520	520
q16	653	676	648	648
q17	1235	1743	1272	1272
q18	7941	7343	7108	7108
q19	804	1004	1136	1004
q20	1883	1974	1794	1794
q21	5363	5045	4924	4924
q22	636	581	593	581
Total cold run time: 54125 ms
Total hot run time: 52153 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191305 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b08a6c13a6ec879671677db1b5e9179387d71044, data reload: false

query1	1009	389	393	389
query2	7836	2538	2511	2511
query3	6728	213	211	211
query4	33655	23720	23404	23404
query5	4323	671	469	469
query6	291	204	203	203
query7	4619	531	308	308
query8	306	252	246	246
query9	9462	2666	2672	2666
query10	481	321	276	276
query11	18084	15228	15283	15228
query12	161	108	106	106
query13	1684	549	428	428
query14	9599	7307	7662	7307
query15	278	193	197	193
query16	8239	633	479	479
query17	1581	773	578	578
query18	2130	394	293	293
query19	229	178	152	152
query20	117	112	149	112
query21	209	121	106	106
query22	4386	4361	4393	4361
query23	34778	33417	33495	33417
query24	6338	2332	2305	2305
query25	486	452	395	395
query26	1203	279	151	151
query27	2221	473	342	342
query28	5121	2445	2399	2399
query29	751	562	411	411
query30	229	191	153	153
query31	993	897	817	817
query32	100	65	57	57
query33	514	357	299	299
query34	787	865	505	505
query35	806	825	746	746
query36	1007	1029	940	940
query37	122	109	77	77
query38	4147	4345	4331	4331
query39	1500	1488	1449	1449
query40	207	116	103	103
query41	46	45	46	45
query42	119	101	103	101
query43	559	545	500	500
query44	1352	823	795	795
query45	187	172	165	165
query46	911	1050	669	669
query47	1897	1925	1828	1828
query48	377	413	335	335
query49	780	483	402	402
query50	671	664	395	395
query51	7131	7269	7078	7078
query52	102	103	93	93
query53	229	262	197	197
query54	483	477	415	415
query55	85	82	77	77
query56	262	260	249	249
query57	1240	1163	1114	1114
query58	242	241	234	234
query59	3167	3217	3095	3095
query60	271	266	255	255
query61	111	125	110	110
query62	910	799	734	734
query63	231	197	199	197
query64	4592	1011	710	710
query65	3322	3221	3255	3221
query66	1086	415	314	314
query67	16108	15865	15456	15456
query68	8775	716	513	513
query69	469	294	254	254
query70	1249	1211	1057	1057
query71	417	289	255	255
query72	6220	3838	4039	3838
query73	672	752	352	352
query74	10160	9361	8948	8948
query75	4286	3144	2665	2665
query76	3957	1176	766	766
query77	809	383	278	278
query78	10053	10196	9469	9469
query79	3443	837	585	585
query80	708	518	440	440
query81	526	266	226	226
query82	617	151	120	120
query83	197	166	147	147
query84	342	87	72	72
query85	794	360	315	315
query86	361	333	296	296
query87	4720	4518	4409	4409
query88	3686	2163	2146	2146
query89	424	334	300	300
query90	1900	197	188	188
query91	139	138	105	105
query92	69	58	54	54
query93	1005	877	537	537
query94	650	409	267	267
query95	343	266	258	258
query96	488	597	274	274
query97	2942	2992	2797	2797
query98	241	209	200	200
query99	1722	1599	1467	1467
Total cold run time: 295572 ms
Total hot run time: 191305 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b08a6c13a6ec879671677db1b5e9179387d71044, data reload: false

query1	0.03	0.03	0.02
query2	0.09	0.02	0.04
query3	0.24	0.07	0.06
query4	1.62	0.10	0.11
query5	0.44	0.42	0.43
query6	1.15	0.66	0.65
query7	0.03	0.01	0.01
query8	0.04	0.02	0.03
query9	0.57	0.49	0.52
query10	0.56	0.57	0.55
query11	0.15	0.09	0.10
query12	0.14	0.10	0.11
query13	0.61	0.61	0.59
query14	2.74	2.76	2.82
query15	0.90	0.84	0.83
query16	0.39	0.38	0.41
query17	1.05	1.05	1.08
query18	0.23	0.21	0.21
query19	1.97	1.87	1.94
query20	0.01	0.01	0.01
query21	15.37	0.97	0.60
query22	0.76	0.74	0.75
query23	15.25	1.38	0.56
query24	2.94	0.96	1.84
query25	0.17	0.18	0.15
query26	0.20	0.14	0.14
query27	0.06	0.05	0.08
query28	14.19	1.50	1.05
query29	12.57	3.90	3.30
query30	0.25	0.09	0.06
query31	2.81	0.58	0.38
query32	3.23	0.55	0.46
query33	3.04	3.08	3.07
query34	16.64	5.16	4.55
query35	4.56	4.49	4.56
query36	0.82	0.49	0.49
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.34 s
Total hot run time: 31.59 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deardeng @hello-stephen @doris-robot @gavinchou