style: rewrite description assign in CheckResultCache in if-else

apache · Mar 1, 2024 · 03be1d6 · 03be1d6
1 parent d276bff
commit 03be1d6
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/...console/src/main/java/org/apache/eventmesh/dashboard/console/health/CheckResultCache.java b/...console/src/main/java/org/apache/eventmesh/dashboard/console/health/CheckResultCache.java
@@ -42,9 +42,10 @@ public void update(String type, Long typeId, HealthCheckStatus status, String re
             cacheMap.put(type, subMap);
         }
         CheckResult oldResult = subMap.get(typeId);
-        String oldDesc = Objects.isNull(oldResult.getResultDesc()) || oldResult.getResultDesc().isEmpty() ? ""
-            : oldResult.getResultDesc() + HealthConstant.NEW_LINE_ENDING;
-        String description = oldDesc + resultDesc;
+        String description = resultDesc;
+        if (oldResult.getResultDesc() != null && !oldResult.getResultDesc().isEmpty()) {
+            description = oldResult.getResultDesc() + HealthConstant.NEW_LINE_ENDING + resultDesc;
+        }
         description += " Latency: " + latency.toString() + "ms";
         CheckResult result = new CheckResult(status, description, LocalDateTime.now(),
             latency, oldResult.getConfig());
@@ -57,7 +58,6 @@ public void update(String type, Long typeId, HealthCheckStatus status, String re
             subMap = new HashMap<>();
             cacheMap.put(type, subMap);
         }
-        CheckResult resultToUpdate = subMap.get(typeId);
         subMap.put(typeId, new CheckResult(status, resultDesc, LocalDateTime.now(), latency, config));
     }