[ISSUE #137] Add an API for the dashboard to read the runtime configurationConfig #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2024 16:53
# Conflicts: # eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Pil0tXia
changed the title
Pil0tXia
reviewed
Apr 29, 2024
Comment on lines
+43
to
+48
| RestTemplate restTemplate = new RestTemplate(); | ||
| String forEntity = | ||
| restTemplate.getForObject("http://" + runtimeEntity.getHost() + ":" + runtimeEntity.getPort() + "/v2/configuration?format=properties", String.class, (Object) null); | ||
| JSONObject jsonMap = JSON.parseObject(forEntity); | ||
| Set<Entry<String, Object>> entries = jsonMap.entrySet(); | ||
| ArrayList<ConfigEntity> configEntities = new ArrayList<>(); |
There was a problem hiding this comment.
RPC implements to EventMesh Runtime, Event Store and Meta should be put in the core module. The console module can call org.apache.eventmesh.dashboard.service.remoting.ConfigRemotingService.
This RemotingService interface needs to differentiate between methods based on the type of operation and the type of configuration, and abstract classes based on the target of the operation. I'll submit a PR for that.
|
@zzxxiansheng Please note that #146 is merged~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation