[ISSUE #21] Implement Connection related code #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD: connection related code: Connection/Client/Connector: Mapper,Entity Connection: ConnectionService,ConnectionDataService others: eventmesh-dashboard.sql test resources MODIFY: pom file: remove dependency of junit, spring-boot-starter-test contains it. pom file: let service module depend on core module.
Pil0tXia
changed the title
Pil0tXia
requested changes
Jan 26, 2024
...onsole/src/main/java/org/apache/eventmesh/dashboard/console/EventmeshConsoleApplication.java
Outdated
Show resolved
Hide resolved
...console/src/main/java/org/apache/eventmesh/dashboard/console/entity/client/ClientEntity.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/eventmesh/dashboard/console/entity/connection/ConnectionEntity.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/eventmesh/dashboard/console/entity/connection/ConnectionEntity.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/eventmesh/dashboard/console/entity/connector/ConnectorEntity.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/eventmesh/dashboard/console/entity/connector/ConnectorEntity.java
Outdated
Show resolved
Hide resolved
...console/src/main/java/org/apache/eventmesh/dashboard/console/entity/client/ClientEntity.java
Outdated
Show resolved
Hide resolved
...console/src/main/java/org/apache/eventmesh/dashboard/console/mapper/client/ClientMapper.java
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/application-dev.yml
Outdated
Show resolved
Hide resolved
# Conflicts: # eventmesh-dashboard-common/src/main/java/org/apache/eventmesh/dashboard/common/Main.java # eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/EventMeshDashboardApplication.java
Pil0tXia
reviewed
Jan 29, 2024
...console/src/main/java/org/apache/eventmesh/dashboard/console/entity/client/ClientEntity.java
Outdated
Show resolved
Hide resolved
...-console/src/main/java/org/apache/eventmesh/dashboard/console/enums/KubernetesPodStatus.java
Outdated
Show resolved
Hide resolved
...-console/src/main/java/org/apache/eventmesh/dashboard/console/enums/KubernetesPodStatus.java
Outdated
Show resolved
Hide resolved
Comment on lines
34
to
36
| @Schema(description = "Dimension of Health Check;0:Unknown, 1:Cluster, 2:Runtime, 3:Topic, 4:Group", defaultValue = "0", allowableValues = {"0", | ||
| "1", "2", "3", "4"}) | ||
| private Integer dimension; |
There was a problem hiding this comment.
"Dimension" is an abstract word. How about "serviceType"?
It will be better to use Enum as class type here. The same as the ConnectorEntity.
There was a problem hiding this comment.
What do you think ServiceType means?
How about just call it checkType?
.../main/java/org/apache/eventmesh/dashboard/console/entity/health/HealthCheckResultEntity.java
Outdated
Show resolved
Hide resolved
add enum support for entity class.
Pil0tXia
reviewed
Jan 29, 2024
...dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/enums/StatusEnum.java
Show resolved
Hide resolved
...sole/src/main/java/org/apache/eventmesh/dashboard/console/enums/KubernetesPodStatusEnum.java
Outdated
Show resolved
Hide resolved
Pil0tXia
reviewed
Jan 29, 2024
...e/src/main/java/org/apache/eventmesh/dashboard/console/entity/connector/ConnectorEntity.java
Outdated
Show resolved
Hide resolved
Pil0tXia
approved these changes
Jan 29, 2024
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
ADD:
connection related code:
Connection/Client/Connector: Mapper,Entity
Connection: ConnectionService,ConnectionDataService
others:
eventmesh-dashboard.sql
test resources
MODIFY:
pom file: remove dependency of junit, spring-boot-starter-test contains it.
pom file: let service module depend on core module.