-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #45] Implement methods from storage-plugin.admin(rocketmq) #55
Conversation
...hboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/eventmesh/dashboard/console/entity/connection/ConnectionEntity.java
Outdated
Show resolved
Hide resolved
...ommon/src/main/java/org/apache/eventmesh/dashboard/common/properties/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
public List<TopicProperties> getTopics() { | ||
List<TopicConfig> topicConfigList = | ||
RocketmqUtils.getTopics(rocketmqProperties.getNamesrvAddr(), rocketmqProperties.getRequestTimeoutMillis()); | ||
List<TopicProperties> topicPropertiesList = new ArrayList<>(); | ||
for (TopicConfig topicConfig : topicConfigList) { | ||
TopicProperties topicProperties = new TopicProperties(); | ||
topicProperties.setRocketmqTopicConfig(topicConfig); | ||
topicPropertiesList.add(topicProperties); | ||
} | ||
return topicPropertiesList; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You implemented these three methods twice. If your implementation in the common
module is generalizable between core
and console
, it's a good idea to standardize the usage in core
and console
, or leave to-do comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a good idea to standardize the usage in
core
andconsole
, or leave to-do comments.
I haven't seen any change related to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly remind that I haven't seen any change related to this review comment.
* added view code * added navigation interaction * added empty pages * add topic statistics ui * complete topic page style --------- Co-authored-by: SUN <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
...mesh/dashboard/console/function/health/check/impl/storage/rocketmq4/Rocketmq4TopicCheck.java
Outdated
Show resolved
Hide resolved
...hboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java
Outdated
Show resolved
Hide resolved
|
||
private TopicConfig rocketmqTopicConfig; | ||
private static final String SEPARATOR = " "; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the SEPARATOR
used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
抄的RocketmqSDK里的 TopicConfig类 我看是连续传多个topic之间用SEPARATOR隔开
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why SEPARATOR
should be placed in a dto?
private int perm; | ||
|
||
private TopicFilterType topicFilterType; | ||
|
||
private int topicSysFlag; | ||
|
||
private boolean order; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to add these fields in a dto?
...ard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/RocketmqProperties.java
Outdated
Show resolved
Hide resolved
… add the mapper method (apache#58) * refactor: add dependency of console module and move controllers into console module. * fix: add logback config, fix application-dev.yml and move `</dependencyManagement>` to root `pom.xml` as pointed out in PR#19. * FirstCommit * remerge * first improve * second improve * third improve * fourth improve * fourth improve * fourth improve * Update and rename EventmeshConsoleApplication.java to EventMeshDashboardApplication.java * rename this starter class file to EventMeshDashboardApplication * rename this starter class file to EventMeshDashboardApplication * change some resource file * improve name * improve name * Modify the fields of the synchronized log table * improve name * improve name * config basic function and config ,runtime,store,cluster sql * try to resolve build error * Some changes in the specification * something rename * one sql update * tag something to do * The distinction between state and status is_delete fields is unified, and selectAll() and batchInsert() are added to all instance tables for subsequent data synchronization. Modification of some fields. * Delete eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/entity/meta/ClusterEntity1.java delete something no use * Delete eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/entity/meta/RuntimeEntity1.java delete something no use * improve something checkstyle error * try to solve something sql test error * try to resolve something test error * try to resolve something test error * something is_delete(error) change to status (apache#3) Co-authored-by: 周倬贤 <[email protected]> --------- Co-authored-by: lambert@arch <[email protected]> Co-authored-by: 周倬贤 <[email protected]>
…ing errors (apache#65) * add back missing build label * Fix module name * add test scope * exclude log4j-to-slf4j * exclude log4j-slf4j-impl * add auto deploy script * add license * refine the script
Fixs #45