-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #76] Add InstanceUser and ACL interfaces #77
Conversation
318228han
commented
Mar 30, 2024
eventmesh-dashboard-console/src/main/resources/application-dev.yml
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/src/main/resources/eventmesh-dashboard.sql
Outdated
Show resolved
Hide resolved
eventmesh-dashboard-console/pom.xml
Outdated
<!-- <dependency>--> | ||
<!-- <groupId>org.apache.eventmesh</groupId>--> | ||
<!-- <artifactId>eventmesh-sdk-java</artifactId>--> | ||
<!-- <version>1.10.0-release</version>--> | ||
<!-- <exclusions>--> | ||
<!-- <exclusion>--> | ||
<!-- <groupId>junit</groupId>--> | ||
<!-- <artifactId>junit</artifactId>--> | ||
<!-- </exclusion>--> | ||
<!-- <exclusion>--> | ||
<!-- <groupId>junit</groupId>--> | ||
<!-- <artifactId>junit-dep</artifactId>--> | ||
<!-- </exclusion>--> | ||
<!-- <exclusion>--> | ||
<!-- <groupId>org.apache.logging.log4j</groupId>--> | ||
<!-- <artifactId>log4j-slf4j-impl</artifactId>--> | ||
<!-- </exclusion>--> | ||
<!-- </exclusions>--> | ||
<!-- </dependency>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to add these indents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will delete them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please double-check that there are no legacy unrenamed entries in the source code outside of this PR~?
@Update("UPDATE service_user SET password=#{password} WHERE id=#{id}") | ||
void updatePasswordById(InstanceUserEntity instanceuserentity); | ||
|
||
@Select("SELECT * FROM service_user WHERE status=1") | ||
List<InstanceUserEntity> selectAll(); | ||
|
||
@Select("SELECT * FROM service_user WHERE id=#{id} AND status=1") | ||
InstanceUserEntity selectById(InstanceUserEntity instanceuserEntity); | ||
|
||
@Select("SELECT * FROM service_user WHERE name=#{name} AND status=1") | ||
List<InstanceUserEntity> selectByName(InstanceUserEntity instanceuserEntity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrenamed service_user
field here.
INSERT INTO eventmesh_dashboard_test.service_user (instance_type, password, cluster_id, name, token, status) | ||
VALUES (1, 'pwd01', 1, 'name01', 'token01', 1); | ||
|
||
INSERT INTO eventmesh_dashboard_test.service_user (instance_type, password, cluster_id, name, token, status) | ||
VALUES (2, 'pwd02', 2, 'name02', 'token02', 1); | ||
|
||
INSERT INTO eventmesh_dashboard_test.service_user (instance_type, password, cluster_id, name, token, status) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrenamed service_user
field here.
This reverts commit 528d6f2.