[ISSUE #86] Add view controllers to console #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzxxiansheng
changed the title
|
I don't know what the original ‘’topiccontroller‘’means, but the name has to be distinguished from the ‘’new topiccontroller‘’ |
|
@zzxxiansheng It's the same. You may reuse the old one. |
Is the topiccore interface in the original topiccontroller called by the viewcontroller（my topic controller）? |
|
@zzxxiansheng Your current TopicController code is just fine, no need to change it. |
Pil0tXia
reviewed
Apr 6, 2024
...ole/src/main/java/org/apache/eventmesh/dashboard/console/entity/config/DefaultConfigKey.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/eventmesh/dashboard/console/modle/dto/config/DynamicGetConfigDTO.java
Outdated
Show resolved
Hide resolved
...va/org/apache/eventmesh/dashboard/console/service/registry/impl/RegistryDataServiceImpl.java
Outdated
Show resolved
Hide resolved
…changes to the controller, and added comments to the config table
|
Please resolve conficts~ |
added 2 commits
April 7, 2024 14:13
# Conflicts: # eventmesh-dashboard-console/pom.xml
Pil0tXia
reviewed
Apr 7, 2024
...main/java/org/apache/eventmesh/dashboard/console/enums/metadata/MetadataServiceTypeEnum.java
Outdated
Show resolved
Hide resolved
Pil0tXia
changed the title
Pil0tXia
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.