Skip to content

[Test] Add testkit infrastructure and refactor simple/converter tests #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GOODBOY008 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Test] Add testkit infrastructure and refactor simple/converter tests #716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b30d618
feat(test): add Excel-specific assertions and test data utilities
GOODBOY008 Nov 28, 2025
dd6b7fa
refactor(test): sample Migrations for simple and convert unit test
GOODBOY008 Nov 28, 2025
5371361
refactor: deprecate legacy converter classes and introduce unified mo…
GOODBOY008 Nov 28, 2025
b8b1899
Merge branch 'main' into feature/ut-refactor
alaahong Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fesod/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,12 @@
<artifactId>jazzer-junit</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
<version>3.24.2</version>
Copy link
Member

@alaahong alaahong Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please manage version with parent dependency management

<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
4 changes: 4 additions & 0 deletions fesod/src/test/java/org/apache/fesod/sheet/converter/ConverterDataListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,12 @@
import org.junit.jupiter.api.Assertions;

/**
* @deprecated Use {@link org.apache.fesod.sheet.testkit.listeners.CollectingReadListener} instead.
* This class mixes data collection with assertions, which violates single responsibility.
* See {@link ConverterIntegrationTest} for the refactored approach.
*
*/
@Deprecated
@Slf4j
public class ConverterDataListener extends AnalysisEventListener<ConverterReadData> {
private final List<ConverterReadData> list = new ArrayList<>();
Expand Down
4 changes: 4 additions & 0 deletions fesod/src/test/java/org/apache/fesod/sheet/converter/ConverterDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@
import org.junit.jupiter.api.TestMethodOrder;

/**
* @deprecated Use {@link ConverterIntegrationTest} instead. This class uses the legacy pattern
* with custom listeners containing embedded assertions. The new test uses
* parameterized tests with {@link org.apache.fesod.sheet.testkit.base.AbstractExcelTest}.
*
*/
@Deprecated
@TestMethodOrder(MethodOrderer.MethodName.class)
public class ConverterDataTest {

Expand Down
4 changes: 3 additions & 1 deletion fesod/src/test/java/org/apache/fesod/sheet/converter/ConverterReadData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@
import org.apache.fesod.sheet.metadata.data.ReadCellData;

/**
*
* @deprecated Use {@link org.apache.fesod.sheet.model.ConverterData} instead.
* This class has been consolidated into a unified model.
*/
@Deprecated
@Getter
@Setter
@EqualsAndHashCode
Expand Down
4 changes: 3 additions & 1 deletion fesod/src/test/java/org/apache/fesod/sheet/converter/ConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@
import org.junit.jupiter.api.TestMethodOrder;

/**
*
* @deprecated Use {@link org.apache.fesod.sheet.unit.converter.ConverterUnitTest} instead.
* The tests have been moved to the unit test package with enhanced coverage.
*/
@Deprecated
@TestMethodOrder(MethodOrderer.MethodName.class)
public class ConverterTest {

Expand Down
4 changes: 3 additions & 1 deletion fesod/src/test/java/org/apache/fesod/sheet/converter/ConverterWriteData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@
import org.apache.fesod.sheet.metadata.data.WriteCellData;

/**
*
* @deprecated Use {@link org.apache.fesod.sheet.model.ConverterData} instead.
* This class has been consolidated into a unified model.
*/
@Deprecated
@Getter
@Setter
@EqualsAndHashCode
Expand Down
5 changes: 5 additions & 0 deletions fesod/src/test/java/org/apache/fesod/sheet/converter/CustomConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestMethodOrder;

/**
* @deprecated Use {@link org.apache.fesod.sheet.integration.converter.CustomConverterIntegrationTest} instead.
* The tests have been refactored to use parameterized tests with format providers.
*/
@Deprecated
@TestMethodOrder(MethodOrderer.MethodName.class)
public class CustomConverterTest {

Expand Down
4 changes: 3 additions & 1 deletion fesod/src/test/java/org/apache/fesod/sheet/converter/ImageData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@
import org.apache.fesod.sheet.converters.string.StringImageConverter;

/**
*
* @deprecated Use {@link org.apache.fesod.sheet.model.ImageData} instead.
* This class has been moved to the model package.
*/
@Deprecated
@Getter
@Setter
@EqualsAndHashCode
Expand Down
4 changes: 4 additions & 0 deletions fesod/src/test/java/org/apache/fesod/sheet/converter/ReadAllConverterDataListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,12 @@
import org.junit.jupiter.api.Assertions;

/**
* @deprecated Use {@link org.apache.fesod.sheet.testkit.listeners.CollectingReadListener} instead.
* This class mixes data collection with assertions, which violates single responsibility.
* See {@link ConverterIntegrationTest} for the refactored approach.
*
*/
@Deprecated
@Slf4j
public class ReadAllConverterDataListener extends AnalysisEventListener<ReadAllConverterData> {
List<ReadAllConverterData> list = new ArrayList<ReadAllConverterData>();
Expand Down
Loading
Loading