-
Notifications
You must be signed in to change notification settings - Fork 469
ci: add concurrency control to GitHub Actions workflows #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds concurrency control to GitHub Actions workflows to prevent redundant workflow executions and optimize CI resource usage. Additionally, it updates error messages in several Java classes to reference the correct API name (FesodSheet instead of the outdated FastExcelFactory).
- Added concurrency groups with
cancel-in-progress: trueto four GitHub Actions workflows - Updated error messages in builder classes to reflect the correct API naming convention
- Changes ensure only one workflow run executes per PR or branch at a time
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/license-check.yml |
Added concurrency control to cancel outdated license check runs |
.github/workflows/codeql-scan.yml |
Added concurrency control to cancel outdated CodeQL security scans |
.github/workflows/ci.yml |
Added concurrency control to cancel outdated Java CI runs |
.github/workflows/ci-docs.yml |
Added concurrency control to cancel outdated documentation CI runs |
fesod-sheet/src/main/java/org/apache/fesod/sheet/write/builder/ExcelWriterTableBuilder.java |
Updated error message to reference FesodSheet instead of FastExcelFactory |
fesod-sheet/src/main/java/org/apache/fesod/sheet/write/builder/ExcelWriterSheetBuilder.java |
Updated error messages to reference FesodSheet instead of FastExcelFactory |
fesod-sheet/src/main/java/org/apache/fesod/sheet/write/builder/CsvWriterBuilder.java |
Updated error message to reference FesodSheet instead of FastExcelFactory |
fesod-sheet/src/main/java/org/apache/fesod/sheet/read/builder/ExcelReaderSheetBuilder.java |
Updated error messages to reference FesodSheet instead of FastExcelFactory |
fesod-sheet/src/main/java/org/apache/fesod/sheet/read/builder/CsvReaderBuilder.java |
Updated error messages to reference FesodSheet instead of FastExcelFactory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public void doRead() { | ||
| if (this.readWorkbook == null) { | ||
| throw new ExcelGenerateException("Must use 'FastExcelFactory.read().csv()' to call this method"); | ||
| throw new ExcelGenerateException("Must use 'FesodSheet.read().csv()' to call this method"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄 Was this an accidental operation? Why are there code modifications included in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@delei Mistake source branch to impl this feature.
91e3d6e to
8e6f2e3
Compare
delei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
This PR adds concurrency control to GitHub Actions workflows to optimize CI resource usage and provide faster feedback.
Changes
codeql-${{ github.event.pull_request.number || github.ref }}ci-${{ github.event.pull_request.number || github.ref }}license-check-${{ github.event.pull_request.number || github.ref }}ci-docs-${{ github.event.pull_request.number || github.ref }}Benefits
Implementation
Each workflow now includes:
This ensures only one workflow run per PR or branch ref executes at a time.