Skip to content

Conversation

@GOODBOY008
Copy link
Member

Summary

This PR adds concurrency control to GitHub Actions workflows to optimize CI resource usage and provide faster feedback.

Changes

  • CodeQL Security Scan: Added concurrency group codeql-${{ github.event.pull_request.number || github.ref }}
  • Java CI: Added concurrency group ci-${{ github.event.pull_request.number || github.ref }}
  • License Check: Added concurrency group license-check-${{ github.event.pull_request.number || github.ref }}
  • Documentation CI: Added concurrency group ci-docs-${{ github.event.pull_request.number || github.ref }}

Benefits

  • Resource Optimization: Automatically cancels outdated workflow runs when new commits are pushed
  • Faster Feedback: Developers get CI results for the latest changes more quickly
  • Cost Reduction: Prevents redundant workflow executions

Implementation

Each workflow now includes:

concurrency:
  group: <workflow-name>-${{ github.event.pull_request.number || github.ref }}
  cancel-in-progress: true

This ensures only one workflow run per PR or branch ref executes at a time.

Copilot AI review requested due to automatic review settings January 7, 2026 02:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds concurrency control to GitHub Actions workflows to prevent redundant workflow executions and optimize CI resource usage. Additionally, it updates error messages in several Java classes to reference the correct API name (FesodSheet instead of the outdated FastExcelFactory).

  • Added concurrency groups with cancel-in-progress: true to four GitHub Actions workflows
  • Updated error messages in builder classes to reflect the correct API naming convention
  • Changes ensure only one workflow run executes per PR or branch at a time

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/license-check.yml Added concurrency control to cancel outdated license check runs
.github/workflows/codeql-scan.yml Added concurrency control to cancel outdated CodeQL security scans
.github/workflows/ci.yml Added concurrency control to cancel outdated Java CI runs
.github/workflows/ci-docs.yml Added concurrency control to cancel outdated documentation CI runs
fesod-sheet/src/main/java/org/apache/fesod/sheet/write/builder/ExcelWriterTableBuilder.java Updated error message to reference FesodSheet instead of FastExcelFactory
fesod-sheet/src/main/java/org/apache/fesod/sheet/write/builder/ExcelWriterSheetBuilder.java Updated error messages to reference FesodSheet instead of FastExcelFactory
fesod-sheet/src/main/java/org/apache/fesod/sheet/write/builder/CsvWriterBuilder.java Updated error message to reference FesodSheet instead of FastExcelFactory
fesod-sheet/src/main/java/org/apache/fesod/sheet/read/builder/ExcelReaderSheetBuilder.java Updated error messages to reference FesodSheet instead of FastExcelFactory
fesod-sheet/src/main/java/org/apache/fesod/sheet/read/builder/CsvReaderBuilder.java Updated error messages to reference FesodSheet instead of FastExcelFactory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

public void doRead() {
if (this.readWorkbook == null) {
throw new ExcelGenerateException("Must use 'FastExcelFactory.read().csv()' to call this method");
throw new ExcelGenerateException("Must use 'FesodSheet.read().csv()' to call this method");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 Was this an accidental operation? Why are there code modifications included in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delei Mistake source branch to impl this feature.

@GOODBOY008 GOODBOY008 force-pushed the ci-concurrency-polish branch from 91e3d6e to 8e6f2e3 Compare January 7, 2026 11:40
@GOODBOY008 GOODBOY008 requested a review from delei January 7, 2026 11:40
Copy link
Member

@delei delei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delei delei merged commit 2883bf8 into apache:main Jan 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants