[FLINK-24379][Formats] Avro Glue Schema Registry table format #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
|
@dannycranmer please review this PR when you have the chance |
z3d1k
suggested changes
Apr 12, 2024
.../src/main/java/org/apache/flink/formats/avro/glue/schema/registry/AvroGlueFormatOptions.java
Outdated
Show resolved
Hide resolved
flink-formats-aws/flink-sql-avro-glue-schema-registry/src/main/resources/META-INF/NOTICE
Outdated
Show resolved
Hide resolved
Fixed param description to match actual default Fix typo in NOTICE
|
@z3d1k I addressed most of the comments. But I am not sure how to implement the IT, in particular for a format using an external registry. The only similar format, flink-avro-confluent-registry, doesn't have any IT. The GRS Serialization/DeserializationSchema IT relies on a AWS account that I assume is available during the CI/CD build. Any reference on how to leverage this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Implement Table API support for Avro with AWS Glue Schema Registry
Verifying this change
Significant changes
@Public(Evolving))The implementation is mostly based on the original PR to the main Flink repo with minor changes. SQL uber-jar has been added and docs fixed and enriched.