[FLINK-35133][Connectors/Cassandra] Adding support for Flink 1.19 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlteoh37
approved these changes
Apr 19, 2024
echauchot
reviewed
Apr 22, 2024
| if: github.repository_owner == 'apache' | ||
| strategy: | ||
| matrix: | ||
| flink_branches: [{ |
There was a problem hiding this comment.
It is true that all the PRs are tested against last 2 Flink versions but don't you think that the weekly workflow should also test against these versions and not only the snapshots ?
There was a problem hiding this comment.
Yeah that makes sense. I need to update to include the new v3.2 branch, so will add them then.
| uses: apache/flink-connector-shared-utils/.github/workflows/ci.yml@ci_utils | ||
| with: | ||
| flink_version: 1.17.2 | ||
| connector_branch: main | ||
| skip_archunit_tests: true |
There was a problem hiding this comment.
Cool that we no more need to test against 1.17.2 and skip the archunit tests !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.