FLINK-39040 Additional body json for GenericJsonAndUrlQueryCreator#17
Merged
Conversation
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Contributor
Author
|
@ferenc-csaky are you OK to have a look at this please. |
davidradl
changed the title
|
Hi @davidradl seems this PR linked a wrong Flink issue. Maybe FLINK-39040 is the wright one. |
Contributor
Author
Thanks for the feedback - I corrected the PR title on Friday. The branch name is still incorrect - but that should not matter - as it does not effect the code. |
ferenc-csaky
reviewed
Feb 9, 2026
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Contributor
Author
|
@ferenc-csaky ready for review again! |
seb-pereira
reviewed
Feb 9, 2026
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Contributor
Author
|
@seb-pereira ready for review again! |
seb-pereira
reviewed
Feb 10, 2026
ferenc-csaky
requested changes
Feb 10, 2026
davidradl
force-pushed
the
FLINK-39039
branch
from
February 10, 2026 15:16
6e1bca4 to
414b874
Compare
Signed-off-by: david_radley@uk.ibm.com <david_radley@uk.ibm.com>
Contributor
Author
|
@ferenc-csaky addressed the review feedback - the while loop simplification was nice :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.