Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34572] Support OceanBase Jdbc Catalog #109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FLINK-34572] Support OceanBase Jdbc Catalog #109

wants to merge 2 commits into from
+1,245 −43

Conversation

whhe
Copy link
Member

@whhe whhe commented Mar 26, 2024

No description provided.

@whhe
Copy link
Member Author

whhe commented Mar 26, 2024

Would you please take a look on this? @leonardBang

@whhe
Copy link
Member Author

whhe commented Mar 30, 2024

@MartijnVisser PTAL

@whhe whhe force-pushed the oceanbase-catalog branch 3 times, most recently from 6b8c734 to 12a77ba Compare May 15, 2024 09:46
@whhe
Copy link
Member Author

whhe commented May 15, 2024

@eskabetxe PTAL

eskabetxe
eskabetxe reviewed May 18, 2024
View reviewed changes
Copy link
Member

@eskabetxe eskabetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments

.../main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseCatalog.java Outdated Show resolved Hide resolved
...rg/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseOracleCatalogITCase.java Outdated Show resolved Hide resolved
.../main/java/org/apache/flink/connector/jdbc/databases/oceanbase/catalog/OceanBaseCatalog.java Outdated Show resolved Hide resolved
@whhe
Copy link
Member Author

whhe commented May 19, 2024

I left some minor comments

Hi @eskabetxe, I updated these files, please take a look again.

@whhe
Copy link
Member Author

whhe commented Jun 3, 2024

@eskabetxe PTAL

@whhe
Copy link
Member Author

whhe commented Jun 17, 2024

Anyone available? @eskabetxe @GOODBOY008 @leonardBang

@whhe whhe force-pushed the oceanbase-catalog branch 3 times, most recently from 132291c to b8dca26 Compare June 28, 2024 10:35
RocMarshal
RocMarshal reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @whhe Thx for the contribution.
Would you mind fixing the failed CI action before the next review ?

@whhe whhe force-pushed the oceanbase-catalog branch 9 times, most recently from 3cd69a4 to 3c15974 Compare July 3, 2024 10:59
@whhe
Copy link
Member Author

whhe commented Jul 3, 2024

Hi, @whhe Thx for the contribution. Would you mind fixing the failed CI action before the next review ?

Hi @RocMarshal, the CI failure is fixed now. PTAL

RocMarshal
RocMarshal reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @whhe for the contribution.
Left a few of comments. PTAL ~

docs/content/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content.zh/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
docs/content.zh/docs/connectors/table/jdbc.md Outdated Show resolved Hide resolved
@whhe
Copy link
Member Author

whhe commented Jul 4, 2024

Thanks @whhe for the contribution. Left a few of comments. PTAL ~

Thanks for your review, the documentations have been updated as suggested. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskabetxe eskabetxe eskabetxe left review comments

@RocMarshal RocMarshal RocMarshal left review comments

Assignees
No one assigned
Labels
component=Connectors/JDBC component=Documentation
Projects
None yet
Milestone
No milestone
3 participants
@whhe @eskabetxe @RocMarshal