Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] change FileSourceSplit to JdbcSourceSplit #145

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[hotfix] change FileSourceSplit to JdbcSourceSplit #145

merged 1 commit into from
Oct 14, 2024

Conversation

caicancai
Copy link
Member

No description provided.

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Oct 10, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@caicancai caicancai changed the title [Hotfix] change FileSourceSplit to JdbcSourceSplit [hotfix] change FileSourceSplit to JdbcSourceSplit Oct 10, 2024
@caicancai
Copy link
Member Author

caicancai commented Oct 11, 2024 •
edited
Loading

cc @RocMarshal

RocMarshal
RocMarshal approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caicancai for the catching
LGTM +1.

@caicancai
Copy link
Member Author

@1996fanrui PTAL, thanks

1996fanrui
1996fanrui approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, merging~

@1996fanrui 1996fanrui self-assigned this Oct 14, 2024
@1996fanrui 1996fanrui merged commit 3b24566 into apache:main Oct 14, 2024
18 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Oct 14, 2024

Awesome work, congrats on your first merged pull request!

@caicancai caicancai deleted the typo branch October 14, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RocMarshal RocMarshal RocMarshal approved these changes

@1996fanrui 1996fanrui 1996fanrui approved these changes

Assignees

@1996fanrui 1996fanrui

Labels
component=JDBC/Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caicancai @1996fanrui @RocMarshal