Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KevDi
Copy link

@KevDi KevDi commented Sep 24, 2023

I have redone the Fix from #5 because no more action is going on there.
I updated to the latest version of the main branch and also added the needed tests.
Hope this is fine so far.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 24, 2023

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@KevDi
Copy link
Author

KevDi commented Oct 19, 2023

Any news on that?

@KevDi KevDi changed the title [FLINK-30371][Connector/JDBC] Fix the problem of JdbcOutputFormat database connection leak [FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak Oct 19, 2023
@eskabetxe
Copy link
Member

Hi @KevDi ,
Checks are not passing, please fix the commit message.
Thanks

@KevDi
Copy link
Author

KevDi commented Oct 27, 2023

Hi @eskabetxe is there a format that should be used for the Commits?

@eskabetxe
Copy link
Member

Should be on same format that you put on title of PT
[FLINK-XXXXX] Some text

And merge commits should be avoided..

Current you have 3 commit messages, the ideal is 1
image

The commit in the middle is ok, the other 2 no

@KevDi
Copy link
Author

KevDi commented Oct 27, 2023

Ok i try to compress the commits to one single commit :)

@KevDi
Copy link
Author

KevDi commented Oct 27, 2023

@eskabetxe had to experience a little bit but now it seems that only one commit is there =)

@eskabetxe
Copy link
Member

@MartijnVisser could you approve the workflow please

@KevDi
Copy link
Author

KevDi commented Nov 10, 2023

@eskabetxe @MartijnVisser i looked into this error but i was unable to resolve it. I removed the mentioned import with explicit imports but then i get an error telling me that some of the static imports are imported before others. If i used the Sort Imports´ on Intellij it removed the imports with the .*` version. Maybe i need some support with that.

@MartijnVisser
Copy link
Contributor

@KevDi You'll need to rebase, the Flink project doesn't do merge commits.

…Method.

This Problem leads to Connection Leaks if some problem occurs.
@KevDi
Copy link
Author

KevDi commented Nov 22, 2023

@MartijnVisser i have done the rebase.

@KevDi
Copy link
Author

KevDi commented Feb 15, 2024

@MartijnVisser any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants