-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][jdbc][docs] Remove dead link #88
base: main
Are you sure you want to change the base?
Conversation
@MartijnVisser @eskabetxe Please take a look, Thank you~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GOODBOY008 Like I've said in the Jira, this shouldn't be addressed per connector but generically for the shared_utils.
Next to that, I'm not sure this solves the problem. You're only checking for dead links in the existing connector docs, but it doesn't actually check the integration of the docs when the Flink documentation is being built. That's where the error occurred.
@MartijnVisser I want to fix dead link in document first. And I also want to add dead link check into https://github.com/apache/flink-connector-shared-utils/tree/ci_utils and pr is apache/flink-connector-shared-utils#33 ,because hugo build cannot check dead link in document. And also in flink repo should add this check too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MartijnVisser PTAL , Thank you~ |
Changes: