[FLINK-30400][build] Stop bundling flink-connector-base #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
Sep 19, 2023
There was a problem hiding this comment.
@zentol @ruanhang1993 does this mean that a connector JAR is always used with Flink's lib so that the flink-connector-base JAR is provided there?
MartijnVisser
force-pushed
the
removeBase
branch
from
ccc3121 to
9239136
Compare
Yes, flink has bundled flink-connector-base jar to flink-dist. https://github.com/apache/flink/blob/master/flink-dist/pom.xml#L156 |
|
@ruanhang1993 Could you rebase the latest main branch and which will trigger the CI again? |
…test scope and to SQL connector with provided scope
ruanhang1993
force-pushed
the
removeBase
branch
from
9239136 to
c980811
Compare
|
@leonardBang Thanks for review. I have rebased the main branch. |
tisonkun
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Stop bundling flink-connector-base.
Ref - FLINK-30400
Verifying this change
This change is a code cleanup without any test coverage.
Significant changes
@Public(Evolving))