Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35064] Update Pulsar dependency to solve the conflict of com.f… #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elon-X
Copy link

@elon-X elon-X commented Apr 11, 2024

This PR fixes the conflict of com.fasterxml.jackson.annotation.JsonFormat$Value

Purpose of the change

fixes the conflict of com.fasterxml.jackson.annotation.JsonFormat$Value

Brief change log

update pom.xml to relocate the 'com.fasterxml' classes to 'org.apache.pulsar.shade.com.fasterxml'

Verifying this change

execute 'mvn clean package -DskipTests', then jar -tf flink-sql-connector-pulsar-4.2-SNAPSHOT.jar | grep 'com.fasterxml', the original 'com.fasterxml' classes are now located under 'org.apache.pulsar.shade.com.fasterxml'

Significant changes

(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
convenience.)

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced
    • If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)

…asterxml.jackson.annotation.JsonFormat$Value
@elon-X
Copy link
Author

elon-X commented Apr 15, 2024

@MartijnVisser @syhily Could you please help approve this PR when you have some free time? Thank you very much.

@syhily
Copy link
Contributor

syhily commented Apr 15, 2024

Sorry, I don't think this PR is accepted, indeed. IIUC, the pulsar-client-all bundle a Jackson internally with a package named org.apache.pulsar.shade.com.fasterxml. The normal jackson can't be shaded into the same package name. Or it may cause more severe issues in class conflicting. I don't think this is a good idea.

@syhily
Copy link
Contributor

syhily commented Apr 15, 2024

The root cause is from pulsar client side with the Jackson shading issues. Shade a jackson causes a lot of issues. I think we should ask pulsar client not to shade the jackson-annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants