[FLINK-36180] Fix batch message data loss #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbingshen
changed the title
syhily
reviewed
Aug 30, 2024
...src/main/java/org/apache/flink/connector/pulsar/source/enumerator/cursor/CursorPosition.java
Show resolved
Hide resolved
syhily
reviewed
Aug 30, 2024
...rc/main/java/org/apache/flink/connector/pulsar/source/reader/PulsarPartitionSplitReader.java
Show resolved
Hide resolved
|
Thanks for your pull request @wenbingshen. I left some questions here. Can you check them? |
@syhily I responded above, PTAL. Thanks. |
|
After discussing with @wenbingshen I think this PR do fixed the batch message consuming issues when the connector is recovered from the checkpoint. LGTM. @reswqa @tisonkun Can you double confirm this PR and merge it? |
tisonkun
approved these changes
Oct 9, 2024
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
When restoring from the state, the unconsumed messages of the batch will be lost.
we should return the next batch index single message for current batch.