Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-37242] Add labels for flink-operator-webhook-service #939

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

dttung2905
Copy link
Contributor

What is the purpose of the change

This requests allow user to set custom labels for flink-operator-webhook-service of kind: Service. This might be useful if the Service is required to have certain labels from the Admission Controller (OPA Gatekeeper for example)

Brief change log

Allows user to set custom labels for flink-operator-webhook-service of kind: Service via webhook.serviceLabels in values.yaml file

Verifying this change

This change is verified as follows:

  • manually deploy the helm chart, and verfiy the envs are correctly passed in to flink-webhook container

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): No
  • The public API, i.e., is any changes to the CustomResourceDescriptors: No
  • Core observer or reconciler logic that is regularly executed: No

Documentation

  • Does this pull request introduce a new feature? Yes
  • If yes, how is the feature documented? docs

@gyfora gyfora merged commit 67aa78b into apache:main Feb 5, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants