Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep #24937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wzx140
Copy link

@wzx140 wzx140 commented Jun 14, 2024

Brief change log

Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep.

ExtendedSqlRowTypeNameSpec nameSpec = new ExtendedSqlRowTypeNameSpec(
        SqlParserPos.ZERO,
        Arrays.asList(
                new SqlIdentifier("column1", SqlParserPos.ZERO),
                new SqlIdentifier("column2", SqlParserPos.ZERO)),
        Arrays.asList(
                new SqlDataTypeSpec(new SqlBasicTypeNameSpec(
                        SqlTypeName.INTEGER,
                        SqlParserPos.ZERO), SqlParserPos.ZERO),
                new SqlDataTypeSpec(new SqlBasicTypeNameSpec(
                        SqlTypeName.INTEGER,
                        SqlParserPos.ZERO), SqlParserPos.ZERO)),
        Collections.emptyList(), true
);
// Throw exception
nameSpec.equalsDeep(nameSpec, Litmus.THROW);

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 14, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@wzx140 wzx140 changed the title [FLINK-35598] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep [FLINK-35598][sql-parser] Fix error comparison type ExtendedSqlRowTypeNameSpec#equalsDeep Jun 14, 2024
@wzx140
Copy link
Author

wzx140 commented Jun 14, 2024

@1996fanrui Could you please review it? Really thanks!

Copy link
Member

@1996fanrui 1996fanrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please review it? Really thanks!

Sorry, I'm not familiar with sql or table module, I'm unable to review this PR.

@wzx140
Copy link
Author

wzx140 commented Jun 14, 2024

Could you please review it? Really thanks!

Sorry, I'm not familiar with sql or table module, I'm unable to review this PR.

Thank you for your response! I understand. I'll find someone else who is more familiar with SQL module to review this PR.

@wzx140
Copy link
Author

wzx140 commented Jun 14, 2024

@dawidwys Could you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants