[BP-2.1][FLINK-38400][table] Fix FILTER condition loss in STDDEV/VAR decomposition by AggregateReduceFunctionsRule

[lincoln-lil]

This is a backport pr for release-2.1 branch.

[flinkbot]

CI report:

• f4b56a2 UNKNOWN
• cdda0aa Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run azure re-run the last Azure build

[snuyanzin]

@lincoln-lil it seems you can not just cherry-pick it since in master there is Calcite 1.36 and in 2.1 Calcite 1.34, AggregateReduceFunctionsRule.java should be adapted accordingly

[lincoln-lil]

@snuyanzin Thank you for helping this! Since it's just a backport and we won't bump up calcite version for release-2.1, we can simply squash the commits into a single commit, WDYT?
Or do you see the needs that we should keep 2 commits as the master branch does? If so, I'll reorg the commits.

[snuyanzin]

can simply squash the commits into a single commit, WDYT

yes, +1 for squashing, however I usually do this after approvals

[lincoln-lil]

I've checked this file locally with a reformatted one from calcite-1.34.0, all the delta changes looks correct.

[lincoln-lil]

can simply squash the commits into a single commit, WDYT

yes, +1 for squashing, however I usually do this after approvals

Sure, I'll ask someone help the review first.

[dylanhz]

LGTM overall, just one minor suggestion.

[dylanhz]

Import this rule.

[lincoln-lil]

Thanks for the tips! But I can’t find a strict rule that requires adding import statements for classes referenced only in comments, just to avoid red underlines in certain IDEs. Moreover, in the existing *RuleTest classes, we’ve consistently followed the convention of not adding such imports (see flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/rules/logical/*RuleTest.java).
Besides that, there’s nothing else that needs to be changed so far, so I’m planning not to make this modification. Does that sound okay to you?

[dylanhz]

Thanks for the feedback, no more comments from me.
Still, I’d prefer fully qualified names in this case.

[lincoln-lil]

I checked the existing RuleTest classes — they don’t need explicit imports because they share the same package as the Flink extended rules, so the IDE doesn’t flag any errors.
In this case, however, the packages are different, so I’ll follow your suggestion and make the change.

[lincoln-lil]

@flinkbot run azure

[snuyanzin]

@lincoln-lil fyi: rerun will not help here
need to wait for #27097 to be merged and then rebase