[FLINK-38556][table] Support filter and project between source and delta join #27159
+2,152
−253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Au-Miner
reviewed
Oct 27, 2025
...ink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java
Show resolved
Hide resolved
...ink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java
Outdated
Show resolved
Hide resolved
...ink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java
Outdated
Show resolved
Hide resolved
|
Thanks for advancing the feature. Let me leave some comments |
github-actions
bot
added
the
community-reviewed
|
@Au-Miner Thanks for the review. Updated! |
Au-Miner
reviewed
Oct 28, 2025
...ink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| ChangelogMode changelogMode = getChangelogMode((StreamPhysicalRel) tableScan); | ||
| if (changelogMode.containsOnly(RowKind.INSERT)) { |
There was a problem hiding this comment.
I remember that CDC source was allowed before, so why is it only allowed to use insert here
There was a problem hiding this comment.
It also allows cdc source. This logic is:
- if the source is INSERT-ONLY source, then pass and return true
- else the source is CDC source
2.1 if the filter pushed down into the source is not applied on one set of upsert key, return false
2.2 else pass and return true
About the logic why the filter must be applied on one set of upsert key when consuming cdc, we have talked before
#27111 (comment), and I also raise a jira for it.
.../main/java/org/apache/flink/table/runtime/operators/join/deltajoin/AsyncDeltaJoinRunner.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support filter and project between source and delta join. After this pr, the join with pattern "source -> calc -> join" can be optimized into delta join.
Brief change log
Verifying this change
UT, IT and harness tests are added.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
@Public(Evolving): no- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented?