[FLINK-38558] Require copy when use heap timer #27160
Open
+32
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The
StateBackend#isSafeToReuseKVStateis exposed to SQL layer to indicate whether it can perform object reuse. Currently it does not consider the heap timer when using RocksDB/ForSt, which may cause checkpoint broken as the FLINK-38558 describes. This PR fixes the implementation.Brief change log
StateBackend#isSafeToReuseKVStateto consider heap timer factory.Verifying this change
This change is a trivial rework and changes the corresponding test of
StateBackendTestBase.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation