Skip to content

[FLINK-33653][runtime] Introduce a benchmark for balanced tasks scheduling. #27161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

[FLINK-33653][runtime] Introduce a benchmark for balanced tasks scheduling. #27161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/PendingRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import java.util.Set;
import java.util.concurrent.CompletableFuture;

final class PendingRequest implements WeightLoadable {
public final class PendingRequest implements WeightLoadable {

private final SlotRequestId slotRequestId;

Expand Down Expand Up @@ -72,7 +72,7 @@ static PendingRequest createBatchRequest(
slotRequestId, resourceProfile, loadingWeight, preferredAllocations, true);
}

static PendingRequest createNormalRequest(
public static PendingRequest createNormalRequest(
SlotRequestId slotRequestId,
ResourceProfile resourceProfile,
LoadingWeight loadingWeight,
Expand Down
2 changes: 1 addition & 1 deletion ...untime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/PhysicalSlotRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public boolean willSlotBeOccupiedIndefinitely() {
return slotWillBeOccupiedIndefinitely;
}

PendingRequest toPendingRequest() {
public PendingRequest toPendingRequest() {
return slotWillBeOccupiedIndefinitely
? PendingRequest.createNormalRequest(
slotRequestId,
Expand Down
4 changes: 2 additions & 2 deletions .../main/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
* belong to the same SlotSharingGroup, tend to be put in the same ExecutionSlotSharingGroup.
* Co-location constraints will be respected.
*/
class LocalInputPreferredSlotSharingStrategy extends AbstractSlotSharingStrategy {
public class LocalInputPreferredSlotSharingStrategy extends AbstractSlotSharingStrategy {

LocalInputPreferredSlotSharingStrategy(
final SchedulingTopology topology,
Expand All @@ -56,7 +56,7 @@ class LocalInputPreferredSlotSharingStrategy extends AbstractSlotSharingStrategy
super(topology, logicalSlotSharingGroups, coLocationGroups);
}

static class Factory implements SlotSharingStrategy.Factory {
public static class Factory implements SlotSharingStrategy.Factory {

public LocalInputPreferredSlotSharingStrategy create(
final SchedulingTopology topology,
Expand Down
2 changes: 1 addition & 1 deletion flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import java.util.Set;

/** Strategy which determines {@link ExecutionSlotSharingGroup} for each execution vertex. */
interface SlotSharingStrategy {
public interface SlotSharingStrategy {

ExecutionSlotSharingGroup getExecutionSlotSharingGroup(ExecutionVertexID executionVertexId);

Expand Down
4 changes: 2 additions & 2 deletions ...ain/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
* the same SlotSharingGroup, tend to be put evenly in each ExecutionSlotSharingGroup. Co-location
* constraints will be respected.
*/
class TaskBalancedPreferredSlotSharingStrategy extends AbstractSlotSharingStrategy {
public class TaskBalancedPreferredSlotSharingStrategy extends AbstractSlotSharingStrategy {

public static final Logger LOG =
LoggerFactory.getLogger(TaskBalancedPreferredSlotSharingStrategy.class);
Expand All @@ -57,7 +57,7 @@ protected Map<ExecutionVertexID, ExecutionSlotSharingGroup> computeExecutionSlot
.build();
}

static class Factory implements SlotSharingStrategy.Factory {
public static class Factory implements SlotSharingStrategy.Factory {

public TaskBalancedPreferredSlotSharingStrategy create(
final SchedulingTopology topology,
Expand Down