Gobblin_password_encryptor should be included in the tarball #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
chavdar
added a commit
that referenced
this pull request
Jan 24, 2016
Gobblin_password_encryptor should be included in the tarball
|
Thank you, Chavdar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all the jars needed by the password encryptor cli tool are in the
gobblin-dist/libdirectory,it's not necessary to build
gobblin-utility.tar.gzmanually as suggested in the documentation .This patch copies the shell script to gobblin-dist/bin. Also added a null check to the password
decryptor to fix the NPE in case of unset passwords.