Skip to content

Conversation

@gustavoharff
Copy link

@gustavoharff gustavoharff commented Oct 17, 2025

This PR is the same as apache/grails-data-mapping#1507, but for Grails 7.

Related to #14506, #14364

The only difference to the original PR is the GormEntityDirtyCheckable class, which was created in Grails 7.

@gustavoharff
Copy link
Author

gustavoharff commented Oct 18, 2025

I edited my commit to fix the code style https://github.com/apache/grails-core/actions/runs/18606687610/job/53059843641

I don't know why, but https://github.com/apache/grails-core/actions/runs/18606687662/job/53059843726 has failure, I ran ./gradlew :grails-test-examples-scaffolding:integrationTest local and it worked well.

@jamesfredley
Copy link
Contributor

https://github.com/apache/grails-core/actions/runs/18606687662/job/53059843726 was likely an intermittent failure, since 17 and 21 completed without issue. I reran it to confirm and full CI is running again on latest commit.

@jdaugherty jdaugherty requested a review from matrei October 24, 2025 15:14
Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable change. @matrei can you please confirm this is acceptable to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

3 participants