GUACAMOLE-1974: Allow deferring received pipe streams for later consumption by name-specific handlers. #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks solid to me! But I'd like another set of eyes on it |
|
I'm also good with the changes - looks pretty straight-forward to me, though admittedly JavaScript is not my strong point. |
necouchman
approved these changes
Aug 1, 2024
mike-jumper
requested changes
Oct 30, 2024
guacamole/src/main/frontend/src/app/client/types/ManagedClient.js
Outdated
Show resolved
Hide resolved
…mption by name-specific handlers.
jmuehlner
force-pushed
the
GUACAMOLE-1974-allow-deferring-of-pipe-streams
branch
from
b4dc7a2
to
2770ef3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the
ManagedClientclass such that pipe streams prior to anonpipehandler being set can still be processed.The idea is that you can register a pipe stream handler for a particular pipe stream name, and that handler will be reliably invoked when a new pipe stream with that name is received, OR if such a pipe stream was already received prior to registration.