GUACAMOLE-374: Restore support for legacy Docker links. #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
reviewed
Oct 2, 2024
mike-jumper
force-pushed
the
fix-docker-links
branch
from
a50d89a
to
b53be08
Compare
mike-jumper
force-pushed
the
fix-docker-links
branch
from
b53be08
to
b96b494
Compare
|
OK - this should be ready now. |
aleitner
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a new
entrypoint.d/000-migrate-docker-links.shscript that migrates environment variables coming from the following Docker links:guacdmysqlpostgressqlserverThat's the entire list of all Docker links we've ever supported historically. Any other variables that may be from other Docker links are untouched.
The migration intentionally occurs before the general deprecated environment variable migration script, as
POSTGRES_PORTcan be either from direct usage of that deprecated environment variable or from a deprecated Docker link.