GUACAMOLE-1020: Perform some additional null checks in restriction verification service. #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necouchman
force-pushed
the
working/login-restrictions
branch
from
cf739d8
to
dfb949c
Compare
mike-jumper
reviewed
Oct 4, 2024
...estrict/src/main/java/org/apache/guacamole/auth/restrict/RestrictionVerificationService.java
Outdated
Show resolved
Hide resolved
...estrict/src/main/java/org/apache/guacamole/auth/restrict/RestrictionVerificationService.java
Outdated
Show resolved
Hide resolved
...estrict/src/main/java/org/apache/guacamole/auth/restrict/RestrictionVerificationService.java
Outdated
Show resolved
Hide resolved
...estrict/src/main/java/org/apache/guacamole/auth/restrict/RestrictionVerificationService.java
Outdated
Show resolved
Hide resolved
...estrict/src/main/java/org/apache/guacamole/auth/restrict/RestrictionVerificationService.java
Outdated
Show resolved
Hide resolved
They seemed a little false-positive to me, but who am I to question Coverity?! |
necouchman
force-pushed
the
working/login-restrictions
branch
from
dfb949c
to
722dc31
Compare
necouchman
force-pushed
the
working/login-restrictions
branch
from
722dc31
to
06786ff
Compare
Okay, I've removed all of the additional |
mike-jumper
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a few null checks and re-arranged a couple of other checks to address some issues that Coverity flagged in the recently-committed login restriction code.