GUACAMOLE-1239: Correct regressions introduced by case sensitive checks for usernames. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitive parameters.
necouchman
force-pushed
the
working/case-insensitive
branch
from
5ef1a9a
to
eaac979
Compare
necouchman
force-pushed
the
working/case-insensitive
branch
2 times, most recently
from
638484f
to
1739efd
Compare
mike-jumper
requested changes
Oct 11, 2024
...bc-base/src/main/java/org/apache/guacamole/auth/jdbc/base/ModeledDirectoryObjectService.java
Outdated
Show resolved
Hide resolved
necouchman
force-pushed
the
working/case-insensitive
branch
from
1739efd
to
dda1189
Compare
I need to take one more look at the |
mike-jumper
approved these changes
Oct 11, 2024
necouchman
force-pushed
the
working/case-insensitive
branch
from
dda1189
to
76d37b4
Compare
|
@mike-jumper Okay, ready for final review, I believe... |
mike-jumper
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the regressions introduced by #902 in implementing case-sensitive usernames, correcting the
@Parameterannotations in a couple of places and moving thecaseSensitiveparameter up to the base mapper class instead of overriding theUserMapperclass. It also moves the warning for the case sensitivity check for MySQL and SQL Server to the Guice module class so that it is only shown once when the module is loaded and not repeatedly for each query (as discussed on the Jira issue).Note that I left the documentation for the
caseSensitiveparameter generic in the base class, and fairly ambiguous - if someone thinks I should put more verbage there around the fact that it currently only applies to usernames, I'm happy to do that, just trying to leave it as generic as possible sense it is in the base class.