GUACAMOLE-925: Add Russian keymap support "ru-ru-qwerty"#1044
Closed
VAGurko wants to merge 3 commits intoapache:mainfrom
VAGurko:main
Closed
GUACAMOLE-925: Add Russian keymap support "ru-ru-qwerty"#1044VAGurko wants to merge 3 commits intoapache:mainfrom VAGurko:main
VAGurko wants to merge 3 commits intoapache:mainfrom
VAGurko:main
Conversation
The parameter "ru-ru-qwerty" has been added to the "guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json" file to support the Russian keyboard layout.
The parameter "FIELD_OPTION_SERVER_LAYOUT_RU_RU_QWERTY" : "Russian (Qwerty)" has been added to the "guacamole/src/main/frontend/src/translations/en.json" file to support the Russian keyboard layout.
…camole interface "секуны", it needs to be fixed to "секунды". In the file "guacamole/src/main/frontend/src/translations/ru.json" the typo of "секуны" has been corrected to "секунды".
mike-jumper
requested changes
Jan 15, 2025
Contributor
mike-jumper
left a comment
mike-jumper
left a comment
There was a problem hiding this comment.
Please separate commit b445aa7 (from GUACAMOLE-2013) into a separate PR. Since GUACAMOLE-2013 is just a typo fix, that PR would be best against patch instead of main.
Otherwise, LGTM (pending merge of apache/guacamole-server#570).
Author
|
Yes, I was in a hurry and made a mistake, I'll go fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter "ru-ru-qwerty" has been added to the "guacamole-ext/src/main/resources/org/apache/guacamole/protocols/rdp.json" file to support the Russian keyboard layout.
The parameter "FIELD_OPTION_SERVER_LAYOUT_RU_RU_QWERTY" : "Russian (Qwerty)" has been added to the "guacamole/src/main/frontend/src/translations/en.json" file to support the Russian keyboard layout.
I added the "Ё" character to support the Russian keyboard layout and corrected the missing comma in the configuration file. Everything is working correctly in the current build of the application.