GUACAMOLE-1479: Change the style of disabled users/groups. #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
requested changes
Dec 11, 2022
There was a problem hiding this comment.
Looks good, however the disabled attribute is currently a custom attribute applied only by the JDBC extensions, so we can't add specific handling for that attribute directly within the webapp as-is.
We could:
- Standardize the attribute at the API level, allowing the webapp to make decisions regarding that attribute.
- Provide a standard API for enabling/disabling a user (ie: an
isDisabled()andsetDisabled()) which could then be exposed within the REST API and handled within the UI appropriately. - Move the handling of styling to the extension defining the attribute.
Given how common enabling/disabling a user or group is likely to be, regardless of backend implementation, I'd lean towards some kind of standardization.
guacamole/src/main/frontend/src/app/settings/templates/settingsUserGroups.html
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/settings/templates/settingsUsers.html
Outdated
Show resolved
Hide resolved
|
@mike-jumper Okay, I've re-worked things to include moving the "disabled" status to the higher level interfaces and pull it out of the Attributes section. And I think the issues with the controller logic for the CSS style should be more reasonable, now. |
|
@mike-jumper Gentle nudge... |
necouchman
force-pushed
the
jira/1479
branch
from
b49318c
to
2f2d372
Compare
|
@mike-jumper Ping... |
mike-jumper
requested changes
Dec 3, 2023
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/User.java
Outdated
Show resolved
Hide resolved
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/UserGroup.java
Outdated
Show resolved
Hide resolved
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/User.java
Outdated
Show resolved
Hide resolved
necouchman
force-pushed
the
jira/1479
branch
3 times, most recently
from
1555983
to
673fa7c
Compare
…and UserGroup classes.
… users and user groups.
|
@mike-jumper Gentle nudge. |
mike-jumper
reviewed
Apr 3, 2024
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Identifiable.java
Outdated
Show resolved
Hide resolved
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Identifiable.java
Outdated
Show resolved
Hide resolved
|
@mike-jumper Ping... |
mike-jumper
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements a style change for users and groups that are disabled, changing the font color to gray and italicizing the user or group name.