GUACAMOLE-61: Add JDBC-specific tokens, including start date and time #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
requested changes
Apr 17, 2023
...base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java
Outdated
Show resolved
Hide resolved
...base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java
Outdated
Show resolved
Hide resolved
...base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java
Outdated
Show resolved
Hide resolved
mike-jumper
requested changes
Aug 28, 2024
...base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java
Outdated
Show resolved
Hide resolved
mike-jumper
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at resolving the challenge specified in the Jira ticket, which is that the default
${GAUC_DATE}and${GUAC_TIME}tokens may not match up to the JDBC start date/time. JDBC-specific tokens have been added - including the start date/time, which are pulled from theActiveConnectionRecordfor the connection - which should allow the date and time to match up with the database records. Other tokens have been added, as well, which will also resolve some other Jira issues, such as wanting to use the connection name in the token.