GUACAMOLE-1525: Support for true fullscreen mode and keyboard lock

[sirux88]

associated JIRA issue: https://issues.apache.org/jira/browse/GUACAMOLE-1525

see also: GUACAMOLE-989 and GUACAMOLE-124

To start fullscreen mode:
Open gucamole's special menu via Ctrl+Alt+Shift and click fullsceen:

("Vollbild" is german for Fullscreen)

[necouchman]

@sirux88 I know you've been frustrated by difficulty of getting PRs merged. Are you still willing to work on this one? I have a couple of minor style issues and then I think this one could be ready to go and close out several long-standing issues.

[sirux88]

@necouchman:
If there's a chance to get it merged by time I'm willing to work on this for sure.
Just let me know.

Since it is only on the jira issue but affecs functionality:

1. True fullscreen mode should work on each maintained browser as stated here => https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API
2. Keyboard lock will only work on chromium based browsers => https://developer.mozilla.org/en-US/docs/Web/API/Keyboard/lock

[necouchman]

Thanks, @sirux88 - Mostly some style change requests. It can seem like some of these are trivial or pedantic, but when you scale it up to the amount of code, here, it makes a difference after a while for the overall readability of the code, so we tend to be very particular about the style being consisten.

Other than that, unless @mike-jumper or @jmuehlner have any concerns, I think it's good.

[sirux88]

Thanks, @sirux88 - Mostly some style change requests. It can seem like some of these are trivial or pedantic, but when you scale it up to the amount of code, here, it makes a difference after a while for the overall readability of the code, so we tend to be very particular about the style being consisten.

I understand that and it's ok. I hope it's fine now @necouchman

To be honest maybe you should add a linter or codestyle checker to your project and setup your rules. So you haven't to explain it to contributers (which is annoying I know)

[necouchman]

To be honest maybe you should add a linter or codestyle checker to your project and setup your rules.

Ah, nice, I will have a look.

[necouchman]

Looks okay to me, now. I will give @mike-jumper and @jmuehlner a while longer to respond with any issues they have, otherwise I'll go ahead and merge it.

[sirux88]

Is the failing docker build a problem @necouchman?
The problem within the build seems not related to this PR.

[necouchman]

Is the failing docker build a problem @necouchman?
The problem within the build seems not related to this PR.

Yeah, seems to be something with the Github infrastructure, not directly related to the PR. I was seeing similar issues the other night when I was rebasing some PRs, and they cleared themselves by the next day. 🤷

[sirux88]

I fell over an problem concerning browsers not implementing keyboard.lock api (e.g. firefox):
If you set fullscreen mode and use the browsers back functionality (e.g. mouse xbutton1) the screen will stay in fullscreen mode.
This might be confusing to some users.

My approach to solve it would be to unload fullscreen mode if the client is "minimized". Meaning guacamole application is going to its homescreen.

But I haven't found an event to register to.
Is there an event like this @necouchman ?

[sirux88]

I fell over an problem concerning browsers not implementing keyboard.lock api (e.g. firefox): If you set fullscreen mode and use the browsers back functionality (e.g. mouse xbutton1) the screen will stay in fullscreen mode. This might be confusing to some users.

My approach to solve it would be to unload fullscreen mode if the client is "minimized". Meaning guacamole application is going to its homescreen.

But I haven't found an event to register to. Is there an event like this @necouchman ?

I ended up in adding it to $scope.$on('$destroy', function clientViewDestroyed() function.
=> solved in my eyes

[necouchman]

I ended up in adding it to $scope.$on('$destroy', function clientViewDestroyed() function.
=> solved in my eyes

Seems reasonable to me.

[necouchman]

One more style change request.