GUACAMOLE-1866: Add capability for users to configure recent connections #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
requested changes
Nov 2, 2023
guacamole/src/main/frontend/src/app/home/controllers/homeController.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/home/directives/guacRecentConnections.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/home/directives/guacRecentConnections.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/settings/services/preferenceService.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/settings/services/preferenceService.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/history/services/guacHistory.js
Outdated
Show resolved
Hide resolved
|
@necouchman If you've made visual changes - would you mind posting a screenshot so we can see what things look like now? |
Sure, not a problem. Here is a quick snapshot of the visual changes I alluded to:
Again, I'm happy to take suggestions on this - I just took a stab at something that would allow the "Recent Connections" header to be easily removed. Here's the preference section...though it should be showing the default value - something to investigate:
|
necouchman
force-pushed
the
jira/1866
branch
from
a408f58
to
4ab265a
Compare
|
Okay, UI - and code issue - is fixed. |
|
Getting back to this after a few months, and on another read-through it LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at an implementation of some initial changes to the Recent Connections that allow the user to control 1) whether they show up at all, and 2) how many connections are kept.
As part of the change I modified the title bar across the top a bit - used the Application Name in the upper-left (instead of "Recent Connections") and made it slightly smaller. I'm perfectly happy to take suggestions on alternatives for this - as many well know by this time, UX design is a weak spot for me :-).