GUACAMOLE-1876: Display points of interest heatmap in history recording player. #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
force-pushed
the
GUACAMOLE-1876-add-player-activity-heatmaps
branch
4 times, most recently
from
a74d87a
to
42da507
Compare
jmuehlner
force-pushed
the
GUACAMOLE-1876-add-player-activity-heatmaps
branch
from
42da507
to
ac6e501
Compare
jmuehlner
force-pushed
the
GUACAMOLE-1876-add-player-activity-heatmaps
branch
2 times, most recently
from
1f45c7c
to
ddf0ce2
Compare
mike-jumper
requested changes
Nov 2, 2023
guacamole/src/main/frontend/src/app/player/directives/player.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/directives/player.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/directives/player.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/services/playerHeatmapService.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/services/playerHeatmapService.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/services/playerHeatmapService.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/services/playerHeatmapService.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/player/services/playerHeatmapService.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1876-add-player-activity-heatmaps
branch
from
ddf0ce2
to
6bd19b4
Compare
|
OK @mike-jumper all your comments should be addressed now. |
mike-jumper
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds heatmaps to the in-browser history recording player, one for frames rendered, and one for key events (if the recording has any - otherwise only the frames heatmap will display).