GUACAMOLE-1904: Broadcast events for mouse/touch events in client. #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuehlner
force-pushed
the
GUACAMOLE-1904-add-listenable-mouse-and-touch-events-for-client
branch
from
05b9d35
to
91645e2
Compare
mike-jumper
requested changes
Jan 31, 2024
guacamole/src/main/frontend/src/app/client/directives/guacClient.js
Outdated
Show resolved
Hide resolved
guacamole/src/main/frontend/src/app/client/directives/guacClient.js
Outdated
Show resolved
Hide resolved
jmuehlner
force-pushed
the
GUACAMOLE-1904-add-listenable-mouse-and-touch-events-for-client
branch
from
91645e2
to
56ca4e9
Compare
mike-jumper
approved these changes
Jan 31, 2024
jmuehlner
deleted the
GUACAMOLE-1904-add-listenable-mouse-and-touch-events-for-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow on from #942, this change further adds new events to be broadcast when mouse or touch events are handled in the client. This is to allow custom fields that live outside the client menu to de-focus text fields and the like so they don't intercept user input that's intended to go into the client (since clicking inside the client won't automatically defocus input elements rendered outside the client, as users might expect).