-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUACAMOLE-1325: Migrate from javax to jakarta namespace. #972
base: next
Are you sure you want to change the base?
Conversation
Well, turns out Tomcat 10 requires Java 11, so that's settled. |
Hi! Thanks a lot for starting this! I've been trying to find time to try it out. |
@z0rb The code has not been merged, so there will be no artifacts or builds with this change, yet. Yes, you will need to clone/patch locally and build yourself to test it out. |
Looks good on Java 17 and Spring-Boot 3.2.5! Thanks again! Hope this makes it into main once the open questions @necouchman mentioned are resolved. |
Thank you for testing! It will not go into |
Thanks for the Tomcat10 patch, I've deployed it and the only issue I have is with the OpenID Connect extension that throw this error :
Mind you, I've only used guacamole-history-recording-storage / guacamole-auth-sso-openid / guacamole-auth-totp / guacamole-auth-jdbc. |
Okay, well, here we go. This PR takes care of the migration from the
javax.*
namespaces to the newjakarta.*
counterparts, updates dependencies, and updates the licenses. I've got it all in a single commit, now, because I couldn't find very clean places to break up the commit - dependency management at this level reminds me of the cat-in-bathtub gif.The code does compile, I'm able to install it into Tomcat 10.1, and run it, log in (JDBC), and start Guacamole session. It's worth noting that this will be a big change in terms of compatibility:
doc/licenses
directory. I suspect I've left a lot of unused cruft around in getting things updated.I'm going to put this in Draft mode for now - I welcome comments, requests for changes, and testing.