Fix SAML read Certificate and private key

[kalaxcortez]

Please validate the reading of the certificate and private key files for SAML, it is only one line and it solves the entire signing issue, please validate and if you do not like the structure, change it but solve it, validate it locally and everything works, Greetings

[necouchman]

@kalaxcortez Thank you for contributing, here. Before we can accept this contribution, a number of things need to be done:

• You need to request a Jira account and open a Jira issue, and your pull request and commit messages need to be tagged with the Jira issue. You can look at any of the existing closed, and many of the open pull requests for examples of this.
• You need to follow established style within the code. For example, you're cuddling braces (} catch () {) - they should be on new lines. Please adjust your style to conform to the rest of the code.
• I think the IOException handling would actually be better placed in the FileGuacamoleProperty class (in guacamole-ext), where it could easily be used by any and all users of the class, rather than just these two properties. It does not seem to be a situation unique to these particular usages of that property.
• You're catching both IOException and GuacamoleException, here, and printing the stack trace - this defeats the purpose of having this particular function throw the GuacamoleException. If you're going to catch IOException, it should be re-thrown as a GuacamoleException, and the throwing of GuacamoleException should be left alone.

please validate and if you do not like the structure, change it but solve it

I believe your suggested changes have merit, and, with some tweaks, would be quite valuable to have added to the project. I'd highly encourage you to take the time to do the steps mentioned above and clean this up for inclusion - and, if you're so inclined, find other ways to contribute to the project.

[mike-jumper]

This will throw a NullPointerException if getProperty() returns null (if the property is not present). Same for the other call to getCanonicalFile().

[mike-jumper]

What is the problem you're encountering that is fixed by calling getCanonicalFile()?

[mike-jumper]

If an error should be logged, it should be logged by a Logger instance with the stack trace logged only at the debug level. We typically do this by logging things twice, with an admin-facing message at the error level and a developer-facing message at the debug level.

That said, I think the proper thing to do here would be to just rethrow the IOException as a GuacamoleException, with the GuacamoleException adding a meaningful message.

[mike-jumper]

It looks like this line was changed only by adding several spaces to the end.