GUAC-1967: Remove duplicate wheel handler registrations. #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops my editor removed trailing spaces automatically. Let me know if that's a problem and I'll see to get that reverted. |
jmuehlner
reviewed
Jul 11, 2024
necouchman
requested changes
Jul 11, 2024
Modern-day browsers abide the standardized wheel event (typed WheelEvent), however to support older browsers the legacy DOMMouseScroll (FireFox) and mousewheel (all others) events are also being registered. However modern browsers support both the wheel event as well as the legacy, which results in the wheel handler being registered multiple times. This results in the wheel handler firing twice instead of once, causing excessive scrolling. This change separates the event registration such that either the modern or the legacy events are registered, and not both.
necouchman
approved these changes
Jul 11, 2024
Nope, LGTM. |
|
@neandrake Actually, one more request - can you please rebase against the |
I've no idea how to do that. I opened a new pull request on the patch branch, #997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern-day browsers abide the standardized
wheelevent (typedWheelEvent), however to support older browsers the legacyDOMMouseScroll(FireFox) andmousewheel(all others) events are also being registered.However modern browsers support both the
wheelevent as well as the legacy, which results in the wheel handler being registered multiple times. This results in the wheel handler firing twice instead of once, causing excessive scrolling.This change separates the event registration such that either the modern or the legacy events are registered, and not both.