GUACAMOLE-1972: Fix writing UTF-8 strings with surrogate pairs #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scottp-dpaw Can you please re-base this against the |
scottp-dpaw
force-pushed
the
GUACAMOLE-1972
branch
from
cbe3525
to
2b9ec3c
Compare
|
Done, sorry about that! |
jmuehlner
reviewed
Oct 21, 2024
| @@ -885,7 +885,12 @@ Guacamole.Keyboard = function Keyboard(element) { | |||
| for (var i = 0; i < str.length; i++) { | |||
|
|
|||
| // Determine keysym of current character | |||
| var codepoint = str.codePointAt ? str.codePointAt(i) : str.charCodeAt(i); | |||
| var codepoint = str.codePointAt(i); | |||
There was a problem hiding this comment.
I don't think we should remove the checks for codePointAt - it was only added in mid-2017.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.