Skip to content

Commit

Permalink
GUACAMOLE-600: Name RDP timeout setting consistent with other protocols.
Browse files Browse the repository at this point in the history
  • Loading branch information
necouchman committed Aug 26, 2024
1 parent f50ccf6 commit 40ec14e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions src/protocols/rdp/settings.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const char fips_nla_mode_warning[] = (
const char* GUAC_RDP_CLIENT_ARGS[] = {
"hostname",
"port",
"server-timeout",
"timeout",
GUAC_RDP_ARGV_DOMAIN,
GUAC_RDP_ARGV_USERNAME,
GUAC_RDP_ARGV_PASSWORD,
Expand Down Expand Up @@ -169,7 +169,7 @@ enum RDP_ARGS_IDX {
/**
* The amount of time to wait for the server to respond, in seconds.
*/
IDX_SERVER_TIMEOUT,
IDX_TIMEOUT,

/**
* The domain of the user logging in.
Expand Down Expand Up @@ -830,7 +830,7 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
settings->security_mode == GUAC_SECURITY_VMCONNECT ? RDP_DEFAULT_VMCONNECT_PORT : RDP_DEFAULT_PORT);

/* Look for timeout settings and parse or set defaults. */
settings->server_timeout =
settings->timeout =
guac_user_parse_args_int(user, GUAC_RDP_CLIENT_ARGS, argv,
IDX_SERVER_TIMEOUT, RDP_DEFAULT_SERVER_TIMEOUT);

Expand Down Expand Up @@ -1744,7 +1744,7 @@ void guac_rdp_push_settings(guac_client* client,
/* Connection */
rdp_settings->ServerHostname = guac_strdup(guac_settings->hostname);
rdp_settings->ServerPort = guac_settings->port;
rdp_settings->TcpAckTimeout = guac_settings->server_timeout * 1000;
rdp_settings->TcpAckTimeout = guac_settings->timeout * 1000;

/* Session */
rdp_settings->ColorDepth = guac_settings->color_depth;
Expand Down
2 changes: 1 addition & 1 deletion src/protocols/rdp/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ typedef struct guac_rdp_settings {
/**
* The timeout, in seconds, to wait for the remote host to respond.
*/
int server_timeout;
int timeout;

/**
* The domain of the user logging in.
Expand Down

0 comments on commit 40ec14e

Please sign in to comment.