Skip to content

Commit

Permalink
GUACAMOLE-377: Do NOT combine display operations vertically unless ed…
Browse files Browse the repository at this point in the history
…ges match exactly.

Doing otherwise can result in display operations overlapping. This is
because combining two vertically adjacent operations that have different
widths causes additional cells to be included that are not covered by
either original operation. If other operations are within those
additional cells, then the operations flushed for the frame will
overlap, consuming unnecessary additional processing and bandwidth.
  • Loading branch information
mike-jumper committed Sep 24, 2024
1 parent d76fdec commit ac4f3c0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/libguac/display-plan-combine.c
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ void PFW_guac_display_plan_combine_vertically(guac_display_plan* plan) {

/* Combine adjacent updates if doing so is advantageous */
if (previous->related_op != NULL && cell->related_op != NULL
&& guac_display_plan_has_common_edge(previous->related_op, cell->related_op)
&& guac_display_plan_combine_if_improved(previous->related_op, cell->related_op)) {
cell->related_op = previous->related_op;
}
Expand Down

0 comments on commit ac4f3c0

Please sign in to comment.