GUACAMOLE-1632: Have spaces written in the appended clipboard. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… appended clipboard."
Add end of line identification when writing to the clipboard, avoiding converted spaces.
Add end of line identification when writing to the clipboard, avoiding converted spaces.
mike-jumper
requested changes
Nov 22, 2022
Comment on lines
+319
to
+321
| /* Keep consistency with vim display */ | ||
| if (codepoint == 0) | ||
| codepoint = 32; |
There was a problem hiding this comment.
Certainly this isn't a workaround for some vim-specific behavior, but rather a missing aspect of the correct way for a terminal emulator to behave? Can you rephrase to capture the nature of what's being done here?
src/terminal/select.c
Outdated
Comment on lines
300
to
305
| int j = end; | ||
| while((!buffer_row->characters[j].value)&& (j > start)){ | ||
| j--; | ||
| } | ||
| if(j != start) | ||
| end = j; |
There was a problem hiding this comment.
Without any comments/documentation here, it's pretty unclear what the intent or purpose of this block of code is. Can you clarify?
src/terminal/select.c
Outdated
Comment on lines
301
to
304
| while((!buffer_row->characters[j].value)&& (j > start)){ | ||
| j--; | ||
| } | ||
| if(j != start) |
There was a problem hiding this comment.
To match the style of established code, please:
- Include a space between
while/ifand the opening paren. - Include spaces around binary operators like
&&.
There was a problem hiding this comment.
Sure, I'll mark some annotations on it and re-format. After investigating we assume that this problem is due to both vim specific behavior and guaca's display & copy logic.
The function of annotated blocks is to ignore any spaces or null chars after a line ends when copying multiple lines after selection. This simple logic gives extra spaces if user select what identified as null in simulator. Thus keeps the clipboard consistent with what user sees in simulator.
|
Closed by #523. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add end of line identification when writing to the clipboard, avoiding converted spaces.