Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUACAMOLE-1332: Add support for certificate fingerprints and auto-accept. #453

Merged

Conversation

necouchman
Copy link
Contributor

This pull requests adds options to support the following additional certificate handling in RDP connections:

  • Trust on First Use (tofu): If a host is not "known" to the underlying FreeRDP library, the certificate will be accepted and the fingerprint stored. This is equivalent to the xfreerdp command line option /cert:tofu.
  • Fingerprint + Hash: You can provide a comma-separated list of certificate hash and fingerprint combinations that FreeRDP will accept for the connection. It's worth noting that I actually don't know the proper way to specify these at the moment, so I've been unable to actually prove this works, but I'm getting identical behavior on the xfreerdp command line as in Guacamole. I've an e-mail out to the FreeRDP mailing list to try to get some guidance on it.

@necouchman necouchman force-pushed the working/freerdp-certificate-fingerprints branch from b7dd4e5 to 1b13024 Compare September 6, 2023 17:56
@necouchman necouchman force-pushed the working/freerdp-certificate-fingerprints branch from 1b13024 to fa4209c Compare September 6, 2023 17:58
@mike-jumper mike-jumper merged commit d592106 into apache:master Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants