GUACAMOLE-1846: Skip user promotion entirely if there are no pending users. #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses an issue where unneeded display flushes would occur even when no users are being promoted. |
mike-jumper
requested changes
Sep 12, 2023
|
@jmuehlner It looks like #457 went into Aaaaaand Mike just beat me to it :-). |
|
Wow ... reviewed at nearly exactly the same time. |
jmuehlner
force-pushed
the
GUACAMOLE-1846-check-user-count-before-syncing-state
branch
2 times, most recently
from
4b32cd8
to
83dc503
Compare
…users. (cherry picked from commit 4b32cd8)
jmuehlner
force-pushed
the
GUACAMOLE-1846-check-user-count-before-syncing-state
branch
from
83dc503
to
96a20ac
Compare
mike-jumper
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.